Sitelet https://github.com/gpuweb/gpuweb/pull/92/files
Skip to content

Provide the attachments state when starting a render pass #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kvark wants to merge 2 commits into from
Closed

Provide the attachments state when starting a render pass #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2e7fc7
Rename attachment states
kvark Sep 28, 2018
c44dc2e
Include AttachmentsState into RenderPassDescriptor
kvark Sep 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions design/sketch.webidl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,13 +397,13 @@ dictionary WebGPUShaderModuleDescriptor {
interface WebGPUShaderModule {
};

// AttachmentState
dictionary WebGPUAttachmentStateDescriptor {
// Description of the framebuffer attachments
dictionary WebGPUAttachmentsStateDescriptor {
sequence<WebGPUTextureFormatEnum> formats;
// TODO other stuff like sample count etc.
};

interface WebGPUAttachmentState {
interface WebGPUAttachmentsState {
};

// Common stuff for ComputePipeline and RenderPipeline
Expand Down Expand Up @@ -444,10 +444,10 @@ enum WebGPUPrimitiveTopology {

dictionary WebGPURenderPipelineDescriptor : WebGPUPipelineDescriptorBase {
WebGPUPrimitiveTopologyEnum primitiveTopology;
sequence<WebGPUBlendState> blendState;
sequence<WebGPUBlendState> blendStates;
WebGPUDepthStencilState depthStencilState;
WebGPUInputState inputState;
WebGPUAttachmentState attachmentState;
WebGPUAttachmentsState attachmentsState;
// TODO other properties
};

Expand Down Expand Up @@ -514,6 +514,7 @@ dictionary WebGPURenderPassDepthStencilAttachmentDescriptor {
};

dictionary WebGPURenderPassDescriptor {
WebGPUAttachmentsState attachmentsState;
sequence<WebGPURenderPassColorAttachmentDescriptor> colorAttachments;
WebGPURenderPassDepthStencilAttachmentDescriptor depthStencilAttachment;
};
Expand Down Expand Up @@ -628,7 +629,7 @@ interface WebGPUDevice {
WebGPUDepthStencilState createDepthStencilState(WebGPUDepthStencilStateDescriptor descriptor);
WebGPUInputState createInputState(WebGPUInputStateDescriptor descriptor);
WebGPUShaderModule createShaderModule(WebGPUShaderModuleDescriptor descriptor);
WebGPUAttachmentState createAttachmentState(WebGPUAttachmentStateDescriptor descriptor);
WebGPUAttachmentsState createAttachmentsState(WebGPUAttachmentsStateDescriptor descriptor);
WebGPUComputePipeline createComputePipeline(WebGPUComputePipelineDescriptor descriptor);
WebGPURenderPipeline createRenderPipeline(WebGPURenderPipelineDescriptor descriptor);

Expand Down