[wgsl] Updating loop section to include for - #757
Merged
Merged
Conversation
dneto0
requested changes
May 6, 2020
othermaciej
previously requested changes
May 6, 2020
kvark
approved these changes
May 7, 2020
Contributor
|
(Adding the flag to add to the agenda to discuss what "simple" means) |
Contributor
|
Discussed at the 2020-05-26 meeting. |
Contributor
|
@litherum said that he's happy with the definition of "simple" provided in another PR. |
Contributor
|
It's this same PR. I said we were okay with the proposal in https://github.com/gpuweb/gpuweb/pull/757/files#r421484430 |
Member
Author
|
I've updated this based on the feedback provided. A |
dj2
commented
Jun 1, 2020
dneto0
approved these changes
Jun 24, 2020
dneto0
left a comment
Contributor
There was a problem hiding this comment.
Approve, but needs a typo fix.
This CL adds the `for` keyword syntax into the language. The `for` is a sugaring on top of the `loop/continue` statement. Fixes #569
dneto0
approved these changes
Jun 24, 2020
Member
Author
|
Travis has passed, https://travis-ci.org/github/gpuweb/gpuweb/builds/701681777 not sure why it isn't reporting the status back. |
ben-clayton
added a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Just dumps all the test lists then returns Also improve some of the error conditions to provide more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds the
forkeyword syntax into the language. Theforis asugaring on top of the
loop/continuestatement.Fixes #569
💥 Error: 400 Bad Request 💥
PR Preview failed to build. (Last tried on Jun 1, 2020, 8:20 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.