Document pipelines - #724
Conversation
Kangz
left a comment
There was a problem hiding this comment.
Looks good overall, this doesn't need to be perfecto to be merged and we can iterate in follow up PRs.
|
@Kangz thank you for the review! |
|
|
||
| Only the lower {{GPURenderPipelineDescriptor/sampleCount}} bits of the mask are considered. | ||
|
|
||
| If the least-significant bit at position |N| of the [=final sample mask=] has value of "0", |
There was a problem hiding this comment.
Final sample mask is a single number, right? What does the LSB at position N of that mean?
There was a problem hiding this comment.
The mask is a number, the LSB at position N is a bit.
There was a problem hiding this comment.
Isn't that just "the bit at position |N|"?
There was a problem hiding this comment.
Pretty much, yes. I just wanted to be more specific and tell where the position is counting from, i.e. "least-significant" part
There was a problem hiding this comment.
Oh, I see. This sounded like "Take the thing at position N, then take the LSB of that" but maybe word this as "If the Nth-least-significant bit"?
|
Thanks @kainino0x , everything is addressed now! |
|
I reopened one of the threads, but feel free to merge anytime |
|
@JusSn would you want to have a look? |
|
@JusSn please review this post-landing! |
* Document pipeline layouts * Document pipelines * Vertex buffer and attribute validation * Detail the rules of bind group equivalence * Refactor algorithm definitions * Indentation fixes
* Document pipeline layouts * Document pipelines * Vertex buffer and attribute validation * Detail the rules of bind group equivalence * Refactor algorithm definitions * Indentation fixes
Relevant investigations: #26, #267
There is more work to be done here, like describing all of the render states, maybe having a separate rasterization section. I don't think we should hold it until everything is done - landing in small chunks is easier.
Also, this is a rough draft, I need to double-check how this is specified in the native APIs and likely extend that.
Preview | Diff