Define extensions, limits, and "valid usages" for requestDevice - #540
Merged
Merged
Conversation
Establishes a pattern, with requestDevice, for hopefully-readable validation rule blocks.
Kangz
approved these changes
Jan 10, 2020
JusSn
approved these changes
Jan 11, 2020
kvark
reviewed
Jan 13, 2020
| {{GPULimits}} describes various limits in the usage of WebGPU on a device. | ||
|
|
||
| One limit value may be <dfn dfn>better</dfn> than another. | ||
| For each limit, "better" is defined. |
Contributor
There was a problem hiding this comment.
nice 👍
I am concerned though. In some cases, requesting higher limits could result in slower implementation, assuming the implementation needs to prepare space and logic to account for the limits...
So it's strange to call them "better" in this context :/
Contributor
Author
There was a problem hiding this comment.
Added a note about this, which I think is sufficient.
kvark
approved these changes
Jan 24, 2020
JusSn
reviewed
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establishes a pattern, with requestDevice, for hopefully-readable validation rule blocks.
Preview | Diff