Add [AllowShared] to setBindGroup - #5202
Merged
Merged
Conversation
This was always intended to be here, we just forgot it when we were adding SharedArrayBuffer support elsewhere (which went through many iterations due to lack of support in WebIDL). Fixes 5201
Contributor
|
Previews, as seen when this build job started (475fdb6): |
mwyrzykowski
approved these changes
May 24, 2025
toji
approved these changes
May 27, 2025
Contributor
GPU Web WG 2025-05-28 Atlantic-time
|
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 26, 2025
…sMixin.setBindGroup`'s `dynamicOffsetData` param. r=#webgpu-reviewers! Upstream IDL change: [`gpuweb`#5202](gpuweb/gpuweb#5202) Differential Revision: https://phabricator.services.mozilla.com/D258788
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jul 27, 2025
…sMixin.setBindGroup`'s `dynamicOffsetData` param. r=webgpu-reviewers,webidl,nical,smaug Upstream IDL change: [`gpuweb`#5202](gpuweb/gpuweb#5202) Differential Revision: https://phabricator.services.mozilla.com/D258788
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Sep 12, 2025
No changes since these bindings already assumed that this API would be [AllowShared].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was always intended to be here, we just forgot it when we were adding SharedArrayBuffer support elsewhere (which went through many iterations due to lack of support in WebIDL).
This is not technically an editorial change but we definitely intended it, so IMO we should go ahead and land it and I'll put it as an FYI on the WG agenda.
Fixes #5201