Change setVertexBuffers to setVertexBuffer - #468
Merged
Merged
Conversation
We determined that setVertexBuffer is both more ergonomic and more performant for JavaScript bindings.
Kangz
approved these changes
Oct 9, 2019
kvark
approved these changes
Oct 9, 2019
This was referenced Oct 9, 2019
Contributor
|
We already decided in the meeting, so merging this. (Force merging because the failure is unrelated and due to the bikeshed update) |
12 of 13 tasks
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
* Refactor dataBytesForCopy to be safer, mostly update usages, fix duplicate offset+ * fix bytesPerSlice computation in layout.ts * fix handling of bytesPerRow/rowsPerImage in test * fix the destination origin/offset in texture checking? * Skip formats for which the checking implementation does not work * TODO encodeExtent3D * Rename files+tests and add descriptions * address comments * helpers for dataBytesForCopy * oops fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We determined in #421 that setVertexBuffer is both more ergonomic and more
performant for JavaScript bindings.
Preview | Diff