Sitelet https://github.com/gpuweb/gpuweb/pull/4517
Skip to content

Increase maxInterStageShaderComponents to 64 - #4517

Merged
kainino0x merged 1 commit into
mainfrom
increase-maxInterStageShaderComponents
Mar 27, 2024
Merged

Increase maxInterStageShaderComponents to 64#4517
kainino0x merged 1 commit into
mainfrom
increase-maxInterStageShaderComponents

Conversation

@teoxoy

@teoxoy teoxoy commented Mar 14, 2024

Copy link
Copy Markdown
Member

Follow-up to #4503, #4509 & #1962 (comment).

We need to increase this limit to 64 since maxInterStageShaderVariables is 16 and the new algorithm counts each variable as 4 components.

@github-actions

github-actions Bot commented Mar 14, 2024 •
edited by mehmetoguzderin
Loading

Copy link
Copy Markdown
Contributor

Previews, as seen when this build job started (d5f1ec7):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@kainino0x kainino0x added this to the Milestone 1 milestone Mar 15, 2024
kainino0x
kainino0x approved these changes Mar 15, 2024
View reviewed changes

@kainino0x kainino0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the base of 60 came from Metal, not Vulkan: "Maximum number of input components to a fragment function" per correspondence doc.

However now that we've dropped Apple3, that's not relevant anymore. LGTM

@kainino0x kainino0x added the tacit resolution queue Editors have agreed and intend to land if no feedback is given label Mar 15, 2024
@kainino0x

kainino0x commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

Resolved in today's meeting to accept this.

@kainino0x kainino0x removed the tacit resolution queue Editors have agreed and intend to land if no feedback is given label Mar 27, 2024
@kainino0x
kainino0x merged commit 51e3223 into main Mar 27, 2024
@kainino0x
kainino0x deleted the increase-maxInterStageShaderComponents branch March 27, 2024 20:32
@Kangz

Kangz commented Apr 9, 2024

Copy link
Copy Markdown
Contributor
GPU Web WG 2024-03-27 
* KN: this was for old Metal devices we don't support any more.
* KG: not because we wanted to reserve room?
* KN: no. Was 64 on Apple3.
* MW: educational iPad for 2019, still supported in the latest software. So WebKit still supports it. But not for WebGPU. It would be a WebGPU Compat device because of other restrictions.
* CW / GT: not for Compat. :)
* KG: recorded, approved. Update Compat to lower this limit separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Milestone 1

Development

Successfully merging this pull request may close these issues.

3 participants

@teoxoy @kainino0x @Kangz