Use = {} syntax in more places, make stencil faces optional - #449
Merged
Merged
Conversation
kvark
approved these changes
Sep 30, 2019
Contributor
Author
|
Realized |
JusSn
approved these changes
Oct 3, 2019
kainino0x
force-pushed
the
default-to-empty
branch
from
October 3, 2019 01:53
b1b0fc1 to
cbe0b69
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 3, 2019
Following WebGPU spec change at gpuweb/gpuweb#449, this CL makes stencilFront and stenciBack optional in GPUDepthStencilStateDescriptor. Bug: 877147 Change-Id: Ied3f567e324c68b179ca51074406d1a6434609f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835362 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#702311}
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…atch latest spec (gpuweb#449) * roll webgpu/types * Update defaultQueue to queue to match latest spec * Update OUTPUT_ATTACHMENT to RENDER_ATTACHMENT to match latest spec Co-authored-by: Kai Ninomiya <kainino@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's one functional change here, which is that
stencilFrontandstencilBackbecome optional (as they always should have been starting with #241).Fixes #420 (I think)
Preview | Diff