Sitelet https://github.com/gpuweb/gpuweb/pull/433/files
Skip to content

Clarify popErrorScope() rejects with OperationError if the device is lost #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kainino0x merged 3 commits into from
Nov 4, 2019
Merged

Clarify popErrorScope() rejects with OperationError if the device is lost #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9780540
Clarify popErrorScope() rejects with AbortError if the device is lost
austinEng Sep 10, 2019
e189990
Update spec/index.bs
austinEng Nov 4, 2019
92832bb
Update design/ErrorHandling.md
austinEng Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion design/ErrorHandling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ If an error is not captured by an error scope, it is passed out to the enclosing

If there are no error scopes on the stack, `popErrorScope()` throws OperationError.

If the device is lost, `popErrorScope()` always rejects.
If the device is lost, `popErrorScope()` always rejects with OperationError.

\* Error scope state is **per-device, per-execution-context**.
That is, when a `GPUDevice` is posted to a Worker for the first time, the new `GPUDevice` copy's error scope stack is empty.
Expand Down
2 changes: 1 addition & 1 deletion spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,7 @@ partial interface GPUDevice {
</script>

{{GPUDevice/popErrorScope()}} throws {{OperationError}} if there are no error scopes on the stack.

{{GPUDevice/popErrorScope()}} rejects with {{OperationError}} if the device is lost.

## Telemetry ## {#telemetry}

Expand Down