Sitelet https://github.com/gpuweb/gpuweb/pull/3626/files
Skip to content

Fix issues in pass end() validation #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdashg merged 1 commit into from
Dec 1, 2022
Merged

Fix issues in pass end() validation #3626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10053,15 +10053,15 @@ called the compute pass encoder can no longer be used.
<div data-timeline=device>
[=Device timeline=] steps:

1. Let |parentEncoder| be |this|.{{GPURenderPassEncoder/[[command_encoder]]}}.
1. If any of the following requirements are unmet,
[$generate a validation error$] and stop.

<div class=validusage>
- |this|.{{GPUCommandsMixin/[[state]]}} must be "[=encoder state/open=]",
- |this|.{{GPUCommandsMixin/[[state]]}} must be "[=encoder state/open=]".
- |parentEncoder|.{{GPUCommandsMixin/[[state]]}} must be "[=encoder state/locked=]".
</div>
1. Let |parentEncoder| be |this|.{{GPUComputePassEncoder/[[command_encoder]]}}.
1. Set |this|.{{GPUCommandsMixin/[[state]]}} to "[=encoder state/ended=]".
1. [=Assert=]: |parentEncoder|.{{GPUCommandsMixin/[[state]]}} is "[=encoder state/locked=]".
1. Set |parentEncoder|.{{GPUCommandsMixin/[[state]]}} to "[=encoder state/open=]".
1. If any of the following requirements are unmet, make
|parentEncoder| [=invalid=] and stop.
Expand Down Expand Up @@ -10630,17 +10630,18 @@ called the render pass encoder can no longer be used.
<div data-timeline=device>
[=Device timeline=] steps:

1. Let |parentEncoder| be |this|.{{GPURenderPassEncoder/[[command_encoder]]}}.
1. If any of the following requirements are unmet,
[$generate a validation error$] and stop.

<div class=validusage>
- |this|.{{GPUCommandsMixin/[[state]]}} must be "[=encoder state/open=]",
- |this|.{{GPUCommandsMixin/[[state]]}} must be "[=encoder state/open=]".
- |parentEncoder|.{{GPUCommandsMixin/[[state]]}} must be "[=encoder state/locked=]".
</div>
1. Let |parentEncoder| be |this|.{{GPURenderPassEncoder/[[command_encoder]]}}.
1. Set |this|.{{GPUCommandsMixin/[[state]]}} to "[=encoder state/ended=]".
1. [=Assert=]: |parentEncoder|.{{GPUCommandsMixin/[[state]]}} is "[=encoder state/locked=]".
1. Set |parentEncoder|.{{GPUCommandsMixin/[[state]]}} to "[=encoder state/open=]".
1. If any of the following requirements are unmet, make |this| [=invalid=] and stop.
1. If any of the following requirements are unmet, make
|parentEncoder| [=invalid=] and stop.

<div class=validusage>
- |this| must be [=valid=].
Expand Down