Add GPURenderPassDescriptor.maxDrawCount - #3005
Conversation
| - |indirectOffset| is a multiple of 4. | ||
| </div> | ||
| 1. Add |indirectBuffer| to the [=usage scope=] as [=internal usage/input=]. | ||
| 1. Increment |this|.{{GPURenderCommandsMixin/[[drawCount]]}} by 1. |
There was a problem hiding this comment.
Surely there should be a condition here "if drawCount > maxDrawCount then mark the encoder as invalid" or something?
There was a problem hiding this comment.
Doing it just in end() seems fine to me, is there a need to duplicate it here?
| - |indirectOffset| is a multiple of 4. | ||
| </div> | ||
| 1. Add |indirectBuffer| to the [=usage scope=] as [=internal usage/input=]. | ||
| 1. Increment |this|.{{GPURenderCommandsMixin/[[drawCount]]}} by 1. |
There was a problem hiding this comment.
Doing it just in end() seems fine to me, is there a need to duplicate it here?
SHA: 8e5a48f Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 8e5a48f Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 8e5a48f Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| - |this| must be [=valid=]. | ||
| - |this|.{{GPUDebugCommandsMixin/[[debug_group_stack]]}} must [=list/is empty|be empty=]. | ||
| - |this|.{{GPURenderPassEncoder/[[occlusion_query_active]]}} must be `false`. | ||
| - |this|.{{GPURenderCommandsMixin/[[drawCount]]}} must be less than |this|.{{GPURenderPassEncoder/[[maxDrawCount]]}}. |
There was a problem hiding this comment.
(Sorry for adding a comment to a merged PR.)
Shouldn't drawCount == maxDrawCount be valid? If it should, this line should be replaced with
this.[[drawCount]] must be equal to or less than this.[[maxDrawCount]].
I want to make a PR if it sounds ok.
There was a problem hiding this comment.
Good catch! Can you make a PR to change this? ("must be less or equal" is more idiomatic I think? Though English is not my native language).
There was a problem hiding this comment.
English isn't my first language, neither, so I googled.
"less than or equal to" - About 60,400,000 results
"equal to or less than" - About 24,400,000 results
"less than or equal to" may be more natural.
Fixes #2189
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Jun 2, 2022, 3:34 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.