Disallow accessing padding - #2987
Merged
Merged
Conversation
Fixes gpuweb#1747 * Implementations must not access padding memory locations in structures and arrays * intentionally not a shader-creation error as it is not expressible in WGSL, but is an implementation requirement
Contributor
dneto0
requested changes
May 31, 2022
dneto0
left a comment
Contributor
There was a problem hiding this comment.
Should this be "will not" instead, as it describes
dneto0
enabled auto-merge (squash)
May 31, 2022 19:52
Contributor
jdarpinian
pushed a commit
to jdarpinian/gpuweb
that referenced
this pull request
Aug 12, 2022
* Disallow accessing padding Fixes gpuweb#1747 * Implementations must not access padding memory locations in structures and arrays * intentionally not a shader-creation error as it is not expressible in WGSL, but is an implementation requirement * Change language to will not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1747
and arrays
in WGSL, but is an implementation requirement