Sitelet https://github.com/gpuweb/gpuweb/pull/285
Skip to content

Redo swapchain with ImageBitmap - #285

Closed
kainino0x wants to merge 1 commit into
gpuweb:masterfrom
kainino0x:unswapchain
Closed

kainino0x wants to merge 1 commit into
gpuweb:masterfrom
kainino0x:unswapchain

Conversation

@kainino0x

@kainino0x kainino0x commented May 10, 2019 •

Copy link
Copy Markdown
Contributor

For preliminary discussion, see kainino0x#4.

There are two motivations behind this.

  • Reintroduce explicit swap control by building out an explicit-swap path that (I think) already exists (transferToImageBitmap+transferFromImageBitmap).
  • Reduce the amount of added API surface (by avoiding an extra rendering context type). (Only sort of achieves this goal.)

Additional considerations:

  • Be compatible with other ImageBitmap APIs.
  • Be compatible native swapchain semantics.

@kainino0x

Copy link
Copy Markdown
Contributor Author

@grorg @RafaelCintron @jdashg, PTAL. I'd like to bring this up at the F2F; it's a tricky topic.

@kainino0x

Copy link
Copy Markdown
Contributor Author

Motivation behind the limitations explained here:
kainino0x#4 (comment)

@kainino0x

Copy link
Copy Markdown
Contributor Author

One open question is how to make it so an app can get rendering results out to an ImageBitmap without it having to get presented via the IBRC.

@kainino0x

Copy link
Copy Markdown
Contributor Author

Per F2F discussion, closing this. I'll open another with a proposal closer to what we were discussing.

@kainino0x kainino0x closed this May 17, 2019
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
* Validation tests for copyImageBitmapToTexture.

Add validation tests for copyImageBitmapToTexture. Left TODOs to
cover more imageBitmap source and more texture dimensions.

* Address reviewer's comments

* Add comments and address more reviewer's comments

* Allow noop copy for copyImageBitmapToTexture

* Address more comments

* Modify the texture/imageBitmap size

* address comments

* address comments

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant