Sitelet https://github.com/gpuweb/gpuweb/pull/2774
Skip to content

Don't reserve buffer, texture, in, out, input, output - #2774

Merged
kdashg merged 1 commit into
gpuweb:mainfrom
dneto0:issue-2768
Apr 26, 2022
Merged

Don't reserve buffer, texture, in, out, input, output#2774
kdashg merged 1 commit into
gpuweb:mainfrom
dneto0:issue-2768

Conversation

@dneto0

@dneto0 dneto0 commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

Also fix the "keywords" script to catch up to recent f16 and const changes.

Fixes: #2768

@dneto0
Don't reserve buffer, texture, in, out, input, output
cc58889 
Also fix the "keywords" script to catch up to recent f16 and const changes.

Fixes: gpuweb#2768
@dneto0 dneto0 added the wgsl WebGPU Shading Language Issues label Apr 19, 2022
@dneto0 dneto0 added this to the V1.0 milestone Apr 19, 2022
@github-actions

github-actions Bot commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

Previews, as seen when this build job started (cc58889):
WebGPU | IDL
WGSL
Explainer

@tidoust tidoust mentioned this pull request Apr 20, 2022
Closed
@kdashg

kdashg commented Apr 26, 2022

Copy link
Copy Markdown
Contributor
WGSL meeting minutes 2022-04-26
  • AB:** Ship it**
  • JB: Some examples I ran into. Others tripped over by internal teams. Take those criticism to heart as haven’t put too much thought into these reserved words
  • MM: Reserved words are only useful if they can have ambiguity later. For things like buffer can’t see where we could have an ambiguity.
  • GR: Spoken about buffer, what about in, out and inout?
  • MM: Written often in HLSL, yea?
  • GR: Right. Will there be a simillar concept? If not and we’re sure of that?
  • JB: Oh, saying we’d like to reserve those as we may want to add those features?
  • GR: No so absolute but don’t wan’t to foreclose
  • MM: Solution for in/out is pointer
  • GR: Want to consider independent of buffer and texture. If we’ve considered and are still good, will go along with that
  • KG: Used to in/out from GLSL. In own code for utility use in/out as variable names. Out used a lot. Maybe because of c++ out var. Would like to not reserve and lean in that direction. Will we never have in/out …
  • MM: For Metal concept of in/out is not sufficient to describe code needed to generate. Function with in/out and caller calls with thread var and acls again with device variable we have to specialize due to template or copy function. Would have opinions if we wanted to add in/out like GLSL and HLSL have.
  • KB: Flush things out a bit, would more prefer to not reserve in/out but still reserve ???. Still have time to add back if we get spooked.
  • JB: This PR not intended to engage future language features. Shouldn’t try to decide if we like in/out in language as part of this PR. Would be happy to drop those words from this PR. Already changed internal examples.
  • MM: Another path, if we want to add in/out we spell them as @in and @out.
  • JR: Right. Same with special attributes on the pointer types.
  • KG: Satisfied we’ve though about them to a sufficient degree.
  • GR: Yup, just wanted to consider independently.

@kdashg
kdashg merged commit 931ad9a into gpuweb:main Apr 26, 2022
github-actions Bot added a commit that referenced this pull request Apr 26, 2022
@dneto0 @github-actions
Don't reserve buffer, texture, in, out, input, output (#2774)
9a9b779 
SHA: 931ad9a
Reason: push, by @kdashg

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 26, 2022
@dneto0 @github-actions
Don't reserve buffer, texture, in, out, input, output (#2774)
010bd39 
SHA: 931ad9a
Reason: push, by @kdashg

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 26, 2022
@dneto0 @github-actions
Don't reserve buffer, texture, in, out, input, output (#2774)
317c550 
SHA: 931ad9a
Reason: push, by @kdashg

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dj2 added a commit to dj2/gpuweb-cts that referenced this pull request Apr 27, 2022
@dj2
Sync reserved words to spec.
cdceaf2 
The spec was updated in gpuweb/gpuweb#2774
to remove the reserved words:

 * buffer
 * in
 * out
 * input
 * output
 * texture

This PR updates the identifier reserved keyword list to match.

Issue: https://github.com/gpuweb/gpuweb/issue/2768
@dj2 dj2 mentioned this pull request Apr 27, 2022
Merged
3 of 7 tasks
dj2 added a commit to gpuweb/cts that referenced this pull request Apr 27, 2022
@dj2
Sync reserved words to spec. (#1308)
8f8ab3b 
The spec was updated in gpuweb/gpuweb#2774
to remove the reserved words:

 * buffer
 * in
 * out
 * input
 * output
 * texture

This PR updates the identifier reserved keyword list to match.

Issue: https://github.com/gpuweb/gpuweb/issue/2768
toji pushed a commit that referenced this pull request Apr 28, 2022
@dneto0 @toji
Don't reserve buffer, texture, in, out, input, output (#2774)
cfd3c03 
Also fix the "keywords" script to catch up to recent f16 and const changes.

Fixes: #2768
@Gordon-F Gordon-F mentioned this pull request Apr 29, 2022
Merged
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
@dneto0 @jdarpinian
Don't reserve buffer, texture, in, out, input, output (gpuweb#2774)
a22eaca 
Also fix the "keywords" script to catch up to recent f16 and const changes.

Fixes: gpuweb#2768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimblandy jimblandy jimblandy approved these changes
@kdashg kdashg kdashg approved these changes
@alan-baker alan-baker alan-baker approved these changes
@litherum litherum Awaiting requested review from litherum

Assignees

No one assigned

Labels

wgsl WebGPU Shading Language Issues

Projects

None yet

Milestone

Milestone 0

Development

Successfully merging this pull request may close these issues.

New reserved word list includes too many common words

4 participants

@dneto0 @kdashg @jimblandy @alan-baker