Finish reworking encoder mixins - #2751
Conversation
|
open q: should it be GPURenderCommandsMixin or GPURenderBundleCommandsMixin? Or something else like GPUCoreRenderCommandsMixin? |
toji
left a comment
There was a problem hiding this comment.
LGTM! I have some comments but nothing that needs to be handled prior to landing this.
| </script> | ||
|
|
||
| {{GPUProgrammablePassEncoder}} has the following internal slots: | ||
| {{GPUBindingCommandsMixin}} is only included by interfaces which include |
There was a problem hiding this comment.
Obviously WebIDL doesn't give us a way to enforce this, so the wording here and in similar scenarios doesn't matter too much, but if we revisit this I'd be tempted to use stronger language like "must only be included by..."
|
|
||
| Issue the following steps on the [=Device timeline=] of |this|.{{GPUObjectBase/[[device]]}}: | ||
| <div class=device-timeline> | ||
| 1. [$Prepare the encoder state$] of |this|. If it returns false, stop. |
There was a problem hiding this comment.
Not introduced in this PR, but it's something I noticed while reviewing it: The verbiage "Prepare the encoder state" sounds a little strange to me throughout this doc, as it sounds like it's doing more work than it actually is. Something like "Validate the encoder state" would be more indicative to me of the action that's actually being taken.
There was a problem hiding this comment.
We named it this way because it can change the encoder to "invalid". But true it doesn't actually change the [[state]] of the encoder now that's distinct from the validity...
fixes #1270
Preview | Diff