Sitelet https://github.com/gpuweb/gpuweb/pull/268/files
Skip to content

Add some more defaults in AttachmentDescriptors #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
litherum wants to merge 1 commit into from
Closed

Add some more defaults in AttachmentDescriptors #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,7 +1011,7 @@ dictionary GPURenderPassColorAttachmentDescriptor {
GPUTextureView? resolveTarget = null;

required GPULoadOp loadOp;
required GPUStoreOp storeOp;
required GPUStoreOp storeOp = "store";

@beaufortfrancois beaufortfrancois Jul 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required GPUStoreOp storeOp = "store";
GPUStoreOp storeOp = "store";

GPUColor clearColor;
};
</script>
Expand All @@ -1027,7 +1027,7 @@ dictionary GPURenderPassDepthStencilAttachmentDescriptor {

required GPULoadOp depthLoadOp;
required GPUStoreOp depthStoreOp;
required float clearDepth;
required float clearDepth = 1.0;

@beaufortfrancois beaufortfrancois Jul 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required float clearDepth = 1.0;
float clearDepth = 1.0;

@kainino0x kainino0x Jul 22, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #283, I think this line becomes obsolete.

@beaufortfrancois beaufortfrancois Jul 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all that's left is GPUStoreOp storeOp = "store";, we should merge. What do you think @kainino0x @kvark ?

@kvark kvark Jul 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@kainino0x kainino0x Jul 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me upload a new PR for just that change since this one is stale.


required GPULoadOp stencilLoadOp;
required GPUStoreOp stencilStoreOp;
Expand Down