Sitelet https://github.com/gpuweb/gpuweb/pull/262/files
Skip to content

Move SwapChain methods from GPUDevice to GPUCanvasContext #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kangz merged 2 commits into from
Apr 2, 2019
Merged

Move SwapChain methods from GPUDevice to GPUCanvasContext #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b482489
Move SwapChain methods from GPUDevice to GPUCanvasContext
beaufortfrancois Apr 1, 2019
7d1f9e5
Address feedback
beaufortfrancois Apr 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion design/ErrorHandling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ Instead, `GPUCommandEncoder.finish` returns an invalid object and generates an e
#### Promise-Returning

- `GPUDevice.createBufferMappedAsync`
- `GPUDevice.getSwapChainPreferredFormat`
- `GPUCanvasContext.getSwapChainPreferredFormat`
- `GPUFence.onCompletion`
- `GPUBuffer.mapReadAsync`
- `GPUBuffer.mapWriteAsync`
Expand Down
15 changes: 7 additions & 8 deletions design/sketch.webidl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,11 +687,16 @@ interface GPUQueue {
};

// SwapChain / CanvasContext
interface GPUCanvasContext {
partial interface GPUCanvasContext {
// Calling configureSwapChain a second time invalidates the previous one,
// and all of the textures it’s produced.
GPUSwapChain configureSwapChain(GPUSwapChainDescriptor descriptor);

Promise<GPUTextureFormat> getSwapChainPreferredFormat(GPUDevice device);
};

dictionary GPUSwapChainDescriptor {
required GPUCanvasContext context;
required GPUDevice device;
required GPUTextureFormat format;
GPUTextureUsageFlags usage = GPUTextureUsage.OUTPUT_ATTACHMENT;
};
Expand Down Expand Up @@ -731,13 +736,7 @@ interface GPUDevice {

GPUCommandEncoder createCommandEncoder(GPUCommandEncoderDescriptor descriptor);

// Calling createSwapChain a second time for the same GPUCanvasContext
// invalidates the previous one, and all of the textures it’s produced.
GPUSwapChain createSwapChain(GPUSwapChainDescriptor descriptor);

GPUQueue getQueue();

Promise<GPUTextureFormat> getSwapChainPreferredFormat(GPUCanvasContext context);
};

dictionary GPUDeviceDescriptor {
Expand Down