Sitelet https://github.com/gpuweb/gpuweb/pull/260
Skip to content

GPUUncapturedErrorEventInit is supposed to have a GPUError, not string - #260

Merged
kainino0x merged 1 commit into
gpuweb:masterfrom
kainino0x:fix-gpuerror-constructor
Apr 1, 2019
Merged

GPUUncapturedErrorEventInit is supposed to have a GPUError, not string#260
kainino0x merged 1 commit into
gpuweb:masterfrom
kainino0x:fix-gpuerror-constructor

Conversation

@kainino0x

@kainino0x kainino0x commented Mar 28, 2019

Copy link
Copy Markdown
Contributor

Also makes GPUError constructible so GPUUncapturedErrorEvent is
constructible.

@kainino0x
GPUUncapturedErrorEventInit is supposed to have a GPUError, not string
784b22c 
Also makes GPUError constructible so GPUUncapturedErrorEvent is
constructible.
@grorg

grorg commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

Discussed at the 1 April Teleconference

@grorg
grorg self-requested a review April 1, 2019 19:53
@kainino0x
kainino0x merged commit 311530a into gpuweb:master Apr 1, 2019
@kainino0x
kainino0x deleted the fix-gpuerror-constructor branch April 1, 2019 20:06
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
Yunchao He
Add more tests for texture resource usage tracking in render (gpuweb#260
6aef1cd 
)

* Add more tests for texture resource usage tracking in render

The new tests are:
  * texture usages by replaced bindings
  * texture usages in bundle

* Addressed feedback from Corentin

* Addressed 2nd round feedback from Kai, Corentin, Austin

* A small change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grorg grorg grorg approved these changes
@Kangz Kangz Kangz approved these changes
@kdashg kdashg kdashg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kainino0x @grorg @Kangz @kdashg