Add optional trailing comma for the attribute syntax. - #2563
Merged
Merged
Conversation
Contributor
mehmetoguzderin
requested changes
Feb 3, 2022
All places that use a variable number of comma-separated things now support trailing commas. However things with a fixed number of comma-separated arguments don't. They are: - array_type_decl - texture_sampler_types - type_decl - variable_qualifier Fixes gpuweb#1243
Kangz
force-pushed
the
trailing-commas
branch
from
February 3, 2022 13:45
9d8629f to
2363895
Compare
Contributor
dneto0
approved these changes
Feb 4, 2022
dneto0
left a comment
Contributor
There was a problem hiding this comment.
Seems harmless to me, but should be approved by the group
Contributor
|
I'm confused. The subject says it apples to attributes. The description lists things that aren't attributes: The code appears to agree with the subject but not the description. |
Contributor
Author
|
The description was to explain that I went through the spec and didn't see another place where to add trailing commas because it was either already supported, or not needed (because it is a restricted number of arguments). |
Contributor
WGSL meeting minutes 2022-02-08
(break!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All places that use a variable number of comma-separated things now
support trailing commas. However things with a fixed number of
comma-separated arguments don't. They are:
Fixes #1243