Use inheritance for debug labels and add them to descriptors - #227
Merged
Merged
Conversation
kainino0x
approved these changes
Mar 2, 2019
kainino0x
left a comment
Contributor
There was a problem hiding this comment.
Seems fine to me.
Can you mention in the summary that this also adds debug labels to Adapter, Device, and SwapChain? (Does it actually make sense to do that?)
| interface GPUObjectBase { | ||
| }; | ||
|
|
||
| dictionnary GPUObjectDescriptorBase { |
Contributor
There was a problem hiding this comment.
dictionnary
here and 3 other places
Contributor
Author
There was a problem hiding this comment.
Whoops, that's a frenchism :) Done
Contributor
|
Discussed at the 1 April Teleconference |
kdashg
approved these changes
Apr 1, 2019
Contributor
|
To merge after moving the 2 partials up into the original definitions, and after #248. |
Contributor
|
ping: #248 has landed |
Contributor
Author
|
Updated to index.bs and folded partial interfaces. |
kvark
approved these changes
Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL, not sure if this is good practice in WebIDL or not.