Change GPUTextureAspect to an enum - #222
Merged
Merged
Conversation
Kangz
requested review from
RafaelCintron,
kainino0x,
kdashg,
kvark and
litherum
February 28, 2019 13:28
Contributor
|
Semantically, I find the original flags to be cleaner. |
kainino0x
reviewed
Feb 28, 2019
Contributor
|
I'm pretty neutral on this. |
Contributor
|
Discussed in the 4 March 2019 meeting |
kdashg
approved these changes
Mar 4, 2019
| enum GPUTextureAspect { | ||
| "everything", | ||
| "just-stencil", | ||
| "just-depth" |
Contributor
There was a problem hiding this comment.
Consider all/depth-only/stencil-only.
The only valid combinations for the bitmask represented either everything (color or depth+stencil) or just depth / just stencil. Change it to an enum to better reflect that.
RafaelCintron
approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only valid combinations for the bitmask represented either
everything (color or depth+stencil) or just depth / just stencil.
Change it to an enum to better reflect that.