Sitelet https://github.com/gpuweb/gpuweb/pull/2141/commits/30712154a6db1e86a22e23148f46faf4477fbac9
Skip to content

Remove no-op minBindingSize text #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvark merged 1 commit into from
Sep 28, 2021
Merged

Remove no-op minBindingSize text #2141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove no-op minBindingSize text 
minBindingSize is never undefined (it defaults to 0), so this "if"
wasn't doing anything.
  • Loading branch information
@kainino0x
kainino0x committed Sep 24, 2021
commit 30712154a6db1e86a22e23148f46faf4477fbac9
12 changes: 5 additions & 7 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3804,13 +3804,11 @@ A {{GPUBindGroup}} object has the following internal slots:
- |resource|.{{GPUBufferBinding/buffer}} is [$valid to use with$] |this|.
- The bound part designated by |resource|.{{GPUBufferBinding/offset}} and
|resource|.{{GPUBufferBinding/size}} resides inside the buffer.
- If |layoutBinding|.{{GPUBindGroupLayoutEntry/buffer}}.{{GPUBufferBindingLayout/minBindingSize}}
is not `undefined`:
- The effective binding size, that is either explict in
|resource|.{{GPUBufferBinding/size}} or derived from
|resource|.{{GPUBufferBinding/offset}} and the full
size of the buffer, is greater than or equal to
|layoutBinding|.{{GPUBindGroupLayoutEntry/buffer}}.{{GPUBufferBindingLayout/minBindingSize}}.
- The effective binding size, that is either explict in
|resource|.{{GPUBufferBinding/size}} or derived from
|resource|.{{GPUBufferBinding/offset}} and the full
size of the buffer, is greater than or equal to
|layoutBinding|.{{GPUBindGroupLayoutEntry/buffer}}.{{GPUBufferBindingLayout/minBindingSize}}.

- If |layoutBinding|.{{GPUBindGroupLayoutEntry/buffer}}.{{GPUBufferBindingLayout/type}} is
<dl class="switch">
Expand Down