Expose all interfaces to DedicatedWorker - #1883
Merged
Merged
Conversation
Contributor
toji
approved these changes
Jun 29, 2021
toji
left a comment
Member
There was a problem hiding this comment.
LGTM with one nit about the Serializable issues.
Contributor
|
This is free to spec, but not free to implement. I think we should hit MVP first. |
kvark
approved these changes
Jul 6, 2021
Contributor
Author
|
Resolved: merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the whole WebGPU API to DedicatedWorker. There's no reason this can't be exposed now (and in fact Chromium already exposes it). This doesn't require multithreading support - just single-threaded access from a worker.
In the second commit, I also tentatively remove the
[Serializable]attribute from all of the interfaces. We already agreed on adding these, but we still have yet to actually fully write down how it works. We should figure out whether we want to keep the partially-defined multithreading in the spec for now. If we do, I'll just cut that commit from the PR.Fixes #1882
Preview | Diff