Sitelet https://github.com/gpuweb/gpuweb/pull/1307/files
Skip to content

Refactor GPURenderPipelineDescriptor API #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kvark wants to merge 7 commits into from
Closed

Refactor GPURenderPipelineDescriptor API #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
03b1084
Refactor GPURenderPipelineDescriptor API
kvark Dec 14, 2020
abdea22
Separate output merger state
kvark Dec 16, 2020
09fa9d0
Rename all the non-root descriptor structs
kvark Dec 16, 2020
db2911e
Also rename vertex and color states
kvark Dec 16, 2020
49eee6f
Update the example hello-cube
kvark Dec 16, 2020
0de1e72
Rename output merger to color write
kvark Dec 17, 2020
2369972
Another pass of fixes and name adjustments
kvark Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 29 additions & 26 deletions samples/hello-cube.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,47 +123,48 @@
verticesWriteArray.set(verticesArray);
verticesBuffer.unmap();

// Bind group binding layout
const transformBufferBindGroupLayoutEntry = {
binding: transformBindingNum, // id[[(0)]]
visibility: GPUShaderStageBit.VERTEX,
type: "uniform-buffer"
};

const bindGroupLayoutDescriptor = { entries: [transformBufferBindGroupLayoutEntry] };
bindGroupLayout = device.createBindGroupLayout(bindGroupLayoutDescriptor);

const pipelineLayoutDescriptor = { bindGroupLayouts: [bindGroupLayout] };
const pipelineLayout = device.createPipelineLayout(pipelineLayoutDescriptor);

// Vertex Input
const positionAttributeDescriptor = {
const positionAttribute = {
shaderLocation: positionAttributeNum, // [[attribute(0)]]
offset: 0,
format: "float4"
};
const colorAttributeDescriptor = {
const colorAttribute = {
shaderLocation: colorAttributeNum,
offset: colorOffset,
format: "float4"
}
const vertexBufferDescriptor = {
attributeSet: [positionAttributeDescriptor, colorAttributeDescriptor],
const vertexBufferLayout = {
attributeSet: [positionAttributeDescriptor, colorAttribute],
stride: vertexSize,
stepMode: "vertex"
};
const vertexInputDescriptor = { vertexBuffers: [vertexBufferDescriptor] };

// Bind group binding layout
const transformBufferBindGroupLayoutEntry = {
binding: transformBindingNum, // id[[(0)]]
visibility: GPUShaderStageBit.VERTEX,
type: "uniform-buffer"
};

const bindGroupLayoutDescriptor = { entries: [transformBufferBindGroupLayoutEntry] };
bindGroupLayout = device.createBindGroupLayout(bindGroupLayoutDescriptor);
const vertexInputState = { vertexBuffers: [vertexBufferLayout] };

// Pipeline
const depthStateDescriptor = {
const depthState = {
depthWriteEnabled: true,
depthCompare: "less"
};

const pipelineLayoutDescriptor = { bindGroupLayouts: [bindGroupLayout] };
const pipelineLayout = device.createPipelineLayout(pipelineLayoutDescriptor);
const vertexStageDescriptor = {
const vertexStage = {
module: shaderModule,
entryPoint: "vertex_main"
};
const fragmentStageDescriptor = {
const fragmentStage = {
module: shaderModule,
entryPoint: "fragment_main"
};
Expand All @@ -183,16 +184,18 @@
},
writeMask: GPUColorWriteBits.ALL
};
const colorWriteState = {
outputs: [colorState]
};
const pipelineDescriptor = {
layout: pipelineLayout,

vertexStage: vertexStageDescriptor,
fragmentStage: fragmentStageDescriptor,
vertexStage: vertexStage,
fragmentStage: fragmentStage,

primitiveTopology: "triangle-list",
colorStates: [colorState],
depthStencilState: depthStateDescriptor,
vertexInput: vertexInputDescriptor
vertexInput: vertexInputState
depthStencilState: depthState,
colorWrite: colorWriteState,
};
pipeline = device.createRenderPipeline(pipelineDescriptor);

Expand Down
Loading