Rename minBufferBindingSize - #1255
Merged
Merged
Conversation
Kangz
approved these changes
Nov 25, 2020
toji
approved these changes
Nov 25, 2020
toji
left a comment
Member
There was a problem hiding this comment.
I had meant to ask about this as part of my previous patch! Agreed that it makes sense now.
bors Bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Nov 30, 2020
1047: Update bind group layout API to match upstream r=cwfitzgerald a=kvark **Connections** Follows gpuweb/gpuweb#1076, gpuweb/gpuweb#1223 (gpuweb/gpuweb#1164), gpuweb/gpuweb#1255, and gpuweb/gpuweb#1256 **Description** Aligns our API closer to the latest changes in WebGPU upstream. We technically don't have to do this, but I believe in the end it would be best if our API gets close to upstream. Note: this is a sensitive change for the users, everybody will get their code broken. So please take a look at the API and see if something is missing or needs improvement, so that we don't have to go through the changes again afterwards. **Testing** Doesn't really need testing. Partially covered by the existing playtest. Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This CL adds unimplemented stubs for the `fwidth` builtin. Issue: gpuweb#1255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it's now a part of
GPUBufferBindingLayout, the fact that it only applies to buffers is implied.Preview | Diff