Sitelet https://github.com/gpuweb/gpuweb/pull/104
Skip to content

Add some process for the materials for meetings - #104

Merged
kvark merged 1 commit into
gpuweb:masterfrom
Kangz:process
Oct 31, 2018
Merged

kvark merged 1 commit into
gpuweb:masterfrom
Kangz:process

Conversation

@Kangz

@Kangz Kangz commented Oct 26, 2018

Copy link
Copy Markdown
Contributor

PTAL!

Comment thread process/HomeworkForMeetings.md Outdated

## Producer homework

In order for members to have time to review material for a meeting, the meat of investigations and proposals have to be posted at least 24 working day hours in advance.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that review material be posted 2 days in advance instead of 1 day in advance. That gives reviewers the opportunity to respond to the pull request in Github, thus giving the producer time to ponder the feedback. With only one day of notice, reviewers are unlikely going to take the time to respond in Github thus leaving the producer to hear feedback for the first time in the meeting.

I do not feel strongly about this but if lively discussion is happening on Github, it might be better to keep it there and only discuss in the meeting when the Github discussion has either died or an agreement cannot be made.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use discussions here to express the positions and argue, eventually reaching consensus like we did for #103. However during the call we can "stamp" the consensus and make it "official", thus merging the PR and figuring out the next steps.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (24 -> 48)

@kvark

kvark commented Oct 31, 2018

Copy link
Copy Markdown
Contributor

I think we can land this now.

@kvark
kvark merged commit 461cee1 into gpuweb:master Oct 31, 2018
kainino0x added a commit that referenced this pull request Jan 29, 2019
This was missed when updating 24 -> 48 in #104.
Kangz pushed a commit that referenced this pull request Jan 29, 2019
This was missed when updating 24 -> 48 in #104.
@Kangz
Kangz deleted the process branch February 1, 2019 14:05
JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Feb 10, 2019
This was missed when updating 24 -> 48 in gpuweb#104.
JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Mar 26, 2019
This was missed when updating 24 -> 48 in gpuweb#104.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants