Changes for depthWriteEnabled/depthCompare/depthClearValue being required - #2342
Merged
Merged
Conversation
…tion error when `depthLoadOp = 'clear'`
Collaborator
Author
|
LGTM (can't officially review because I created the PR). I looked a bit for other places that might be missing and didn't find any, but didn't try a dry run. |
ErichDonGubler
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Aug 16, 2023
…ired (gpuweb#2342) * Changes needed to CTS if depthWriteEnabled and depthCompare are required * Changes needed to CTS if `depthClearValue` undefined becomes a validation error when `depthLoadOp = 'clear'` --------- Co-authored-by: Gregg Tavares <gman@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work was done by @greggman, I just cherry-picked his commits into a PR.
Issue: gpuweb/gpuweb#3849
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.