Conversation
It was originally fixed by gpodder#1822 and later accidentally reverted by gpodder#1855. Added comments to prevent future issues. Discovered-by: Cory L Hug
Member
|
Isn't it breaking other platforms? Sorry: I don't remember, maybe yt-dlp update is only for windows? |
Member
Author
|
That code is only called for the Windows and Mac builds. And 'pythonw' exists for all platforms to run scripts in a GUI, so a terminal doesn't open while it runs. I probably should have mentioned all of that in the comments as well, I'll update the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was originally fixed by #1822 and later accidentally reverted by #1855. Added comments to prevent future issues.
Discovered-by: Cory L Hug