Adapt youtube-dl plugin to latest yt-dlp - #1520
Merged
Merged
Conversation
This prevents unnecessary warnings from yt-dlp.
Contributor
Author
|
Actually it was not too hard to make this compatible with the old version of yt-dlp and youtube-dl. Not tested though. |
|
Thanks!
Von: Teemu Ikonen ***@***.***>
Gesendet: Freitag, 30. Juni 2023 20:19
An: gpodder/gpodder ***@***.***>
Cc: Subscribed ***@***.***>
Betreff: Re: [gpodder/gpodder] Adapt youtube-dl plugin to latest yt-dlp (PR #1520)
Actually it was not too hard to make this compatible with the old version of yt-dlp and youtube-dl. Not tested though.
—
Reply to this email directly, view it on GitHub <#1520 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNRICQFJKGZHVE7B7XO2RDXN4KANANCNFSM6AAAAAAZ2EIZME> .
You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/ACNRICS4F6NKJYBHEHKSFODXN4KANA5CNFSM6AAAAAAZ2EIZMGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTAINAN6.gif> Message ID: ***@***.*** ***@***.***> >
|
auouymous
added a commit
that referenced
this pull request
Jun 30, 2023
Member
|
Thank you. fccea8a bumps the required yt-dlp version so those with an older yt-dlp will be told to upgrade when they have trouble with the no_color change. Youtube-dl can't be tested until they put out a release for the 2023.02.17 youtube.com breakage. It is under active developement, just no releases. At some point we can drop support, but for now we will try to remain compatible and assume all changes work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two problems found when using the youtube-dl plugin with the latest yt-dlp (2023.06.22).
Use
'color': 'no_color'in yt-dlp params instead of'no_color': True. This prevents warning log output.The internal member
_VALID_URL_REis now an iterable. Adapt theis_supported_urlfunction and the regex cache code.This likely breaks compatibility with original youtube-dl.