Sitelet https://github.com/gpodder/gpodder/pull/1441/files
Skip to content

delete tags before modifying #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auouymous merged 4 commits into from
Dec 7, 2022
Merged

delete tags before modifying #1441

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36a0f42
delete tags before modifying
Skitals Nov 28, 2022
463f77f
remove white space
Skitals Nov 28, 2022
4d71dd8
add 'remove_before_modify' option
Skitals Nov 28, 2022
b35bed6
add 'remove_before_modify' option
Skitals Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions share/gpodder/extensions/tagging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
'auto_embed_coverart': False,
'set_artist_to_album': False,
'set_version': 4,
'modify_tags': True
'modify_tags': True,
'remove_before_modify': False
}


Expand All @@ -82,7 +83,7 @@ def remove_tags(self):
audio.delete()
audio.save()

def write_basic_tags(self, modify_tags, set_artist_to_album, set_version):
def write_basic_tags(self, remove_before_modify, modify_tags, set_artist_to_album, set_version):
audio = File(self.filename, easy=True)

if audio is None:
Expand All @@ -93,6 +94,9 @@ def write_basic_tags(self, modify_tags, set_artist_to_album, set_version):
audio.add_tags()

if modify_tags:
if remove_before_modify:
audio.delete()

if self.album is not None:
audio.tags['album'] = self.album

Expand Down Expand Up @@ -284,7 +288,8 @@ def write_info2file(self, info, episode):
if self.container.config.always_remove_tags:
audio.remove_tags()
else:
audio.write_basic_tags(self.container.config.modify_tags,
audio.write_basic_tags(self.container.config.remove_before_modify,
self.container.config.modify_tags,
self.container.config.set_artist_to_album,
self.container.config.set_version)

Expand Down