Sitelet https://github.com/gpodder/gpodder/pull/1381
Skip to content

Revert "Don't try to download media files with youtube-dl extension" - #1381

Merged
auouymous merged 1 commit into
masterfrom
revert-1347-ytdl-no-audio-video-files
Sep 2, 2022
Merged

auouymous merged 1 commit into
masterfrom
revert-1347-ytdl-no-audio-video-files

Conversation

@auouymous

Copy link
Copy Markdown
Member

Reverts #1347

Unfixes #1263.
Fixes #1364.
May fix unsupported DRM issue in #1311.

@tpikonen

Copy link
Copy Markdown
Contributor

Yes, this should be reverted. The spreaker feeds seem to be working now and I submitted a fix to the yt-dlp audioboom extension, which was the other failing example in #1263.

A more generic fix to #1263 could be to use util.filename_from_url() to detect direct media links in the youtube_dl extension.

@auouymous
auouymous merged commit e510b1e into master Sep 2, 2022
@auouymous
auouymous deleted the revert-1347-ytdl-no-audio-video-files branch September 2, 2022 22:07
@auouymous

Copy link
Copy Markdown
Member Author

The spreaker feed is failing to find formats with this PR applied, so I've reopened #1263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does not honor 'youtube-dl.manage-downloads' setting with youtube channels

2 participants