Replace SimpleMessageArea with GtkInfoBar when resuming - #1372
Merged
Merged
Conversation
Member
|
I like it, the message stands out now. I'll review the patch in a day or two. |
elelay
reviewed
Oct 13, 2022
Member
|
|
tpikonen
force-pushed
the
resume-infobar
branch
from
October 16, 2022 14:07
d229f9b to
81d5293
Compare
Contributor
Author
|
Thanks for the review. Rebased to master, the suggested fix applied and squashed. |
auouymous
requested changes
Oct 22, 2022
auouymous
requested changes
Oct 22, 2022
Remove unused SimpleMessageArea code.
tpikonen
force-pushed
the
resume-infobar
branch
from
October 24, 2022 08:43
d323d15 to
9130f39
Compare
Contributor
Author
|
The infobar is now not removed when switching tabs, the previous fix is squashed and this branch is rebased to master. |
Member
|
Thanks for the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the custom SimpleMessageArea widget in the Progress tab and replaces it with a standard GtkInfoBar. The functionality is identical, but I added a close button to the bar, so it can be dismissed immediately. The bar also disappears when changing to the first notebook tab, as before.
Also does some cleanups (change GtkGrid to GtkBox layouts) in the Download limits area.