Add/remove extension preferences buttons when loaded/unloaded. - #1330
Merged
auouymous merged 2 commits intoJul 13, 2022
Merged
Conversation
The user must currently close preferences and reopen to configure extensions that provide a preferences UI. This is a problem when the user does not know the extension has preferences, but the sudden appearance of the button when an extension is enabled might catch the user's attention. Furthermore, removing the button when the extension is unloaded prevents any confusion as to why it is still there.
tpikonen
reviewed
Jul 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user must currently close preferences and reopen to configure extensions that provide a preferences UI. This is a problem when the user does not know the extension has preferences, but the sudden appearance of the button when an extension is enabled might catch the user's attention.
Furthermore, removing the button when the extension is unloaded prevents any confusion as to why it is still there.