Sitelet https://github.com/gpodder/gpodder/pull/1286
Skip to content

MPRIS extension fixes - #1286

Merged
auouymous merged 2 commits into
gpodder:masterfrom
tpikonen:mpris-negpos
Apr 29, 2022
Merged

auouymous merged 2 commits into
gpodder:masterfrom
tpikonen:mpris-negpos

Conversation

@tpikonen

Copy link
Copy Markdown
Contributor

Two commits:

  1. Some players occasionally send negative 'pos' values to MPRIS. Clamp these values to 0.
  2. The fix for exceptions caused by missing position values in Fix exceptions on mpris-listener extension #1265 causes 'pos' to be set to None, which causes further exceptions. If there's no position (or status) property, do nothing. Refactor the code in question slightly.

If negative position values are received from MPRIS, treat them as 0.
@auouymous
auouymous merged commit 3b2415e into gpodder:master Apr 29, 2022
@auouymous

Copy link
Copy Markdown
Member

LGTM, thanks.

@tpikonen
tpikonen deleted the mpris-negpos branch April 29, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants