Sitelet https://github.com/gpodder/gpodder/pull/1265/files
Skip to content

Fix exceptions on mpris-listener extension #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auouymous merged 2 commits into from
Apr 9, 2022
Merged

Fix exceptions on mpris-listener extension #1265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aae54f
mpris-listener: Fix exceptions with unsupported properties
tpikonen Apr 4, 2022
f97116d
mpris-listener: Fix exceptions on logging
tpikonen Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions share/gpodder/extensions/mpris-listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def update(self, **kwargs):
('status' not in kwargs or kwargs['status'] == 'Playing') and not
subsecond_difference(cur['pos'], kwargs['pos'])):
logger.debug('notify Stopped: playback discontinuity:' +
'calc: %f observed: %f', cur['pos'], kwargs['pos'])
'calc: %r observed: %r', cur['pos'], kwargs['pos'])
self.notify_stop()

if ((kwargs['pos']) == 0 and
Expand Down Expand Up @@ -159,7 +159,7 @@ def update(self, **kwargs):
if self.status == 'Playing':
self.notify_playing()
else:
logger.debug('notify Stopped: status %s', self.status)
logger.debug('notify Stopped: status %r', self.status)
self.notify_stop()

def getinfo(self):
Expand Down Expand Up @@ -289,12 +289,20 @@ def on_seeked(self, position):
def query_position(self, sender):
proxy = self.bus.get_object(sender, self.PATH_MPRIS)
props = dbus.Interface(proxy, self.INTERFACE_PROPS)
return props.Get(self.INTERFACE_MPRIS, 'Position')
try:
pos = props.Get(self.INTERFACE_MPRIS, 'Position')
except:
pos = None
return pos

def query_status(self, sender):
proxy = self.bus.get_object(sender, self.PATH_MPRIS)
props = dbus.Interface(proxy, self.INTERFACE_PROPS)
return props.Get(self.INTERFACE_MPRIS, 'PlaybackStatus')
try:
status = props.Get(self.INTERFACE_MPRIS, 'PlaybackStatus')
except:
status = None
return status


class gPodderNotifier(dbus.service.Object):
Expand Down