Refactor play_or_download() episode action code. - #1252
Merged
Merged
Conversation
Streaming was always possible (gpodder#867) for all audio and video episodes if an audio player was configured. Now it is only possible if a player is configured for the episode's type. Methods have been added to PodcastEpisode that are either now used by actions or replicate the conditions used by actions to filter selections. This will help prevent mismatched conditions between play_or_download() and episode actions. And play_or_download() is easier to reason about and should prevent future bugs such as gpodder#1250. Fixes gpodder#1250.
Member
|
Still an issue with the Cancel button when the Progress tab is active after cancelling a task:
|
Member
Author
|
This PR is only for the episode list actions. I have a partial fix for the progress tab cancel button/menutiem but needed to shelve it while fixing my mistake from #1250. There is also an issue with the Open/Play/Preview/Stream button/menuitems when using a mixed selection that will need to be dealt with later. |
Member
|
ok, so merge it when you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streaming was always possible (#867) for all audio and video episodes if an audio player was configured. Now it is only possible if a player is configured for the episode's type.
Methods have been added to PodcastEpisode that are either now used by actions or replicate the conditions used by actions to filter selections. This will help prevent mismatched conditions between play_or_download() and episode actions. And play_or_download() is easier to reason about and should prevent future bugs such as #1250.
Fixes #1250.