gPodderExportToLocalFolder: Use GtkDialog.add_buttons() - #1222
Merged
Merged
Conversation
Member
|
LGTM, but the |
Create the dialog buttons with GtkDialog.add_buttons(). This places them either to the dialog action area, or to the headerbar, accoording to the system setting. Also set 'do-overwrite-confirmation' property of the Dialog to False.
tpikonen
force-pushed
the
export-headerbar
branch
from
February 5, 2022 20:27
d37787d to
e9cb4e9
Compare
Contributor
Author
|
That was a pure mistake. Fixed now. |
Member
|
Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the gPodderExportToLocalFolder dialog adds the OK and Cancel buttons to the action area explicitly in the ui-file. This causes Gtk warnings on systems which are configured to have dialog the buttons in the window headerbar.
The correct way is to add the buttons with GtkDialog.add_buttons() method, which places the buttons either to the header bar or the action area depending on system settings.
Also fix strings in the 'File already exists' confirmation dialog.