Sitelet https://github.com/gpodder/gpodder/pull/1134
Skip to content

Gtk UI: Use the built-in Gtk3 about dialog - #1134

Closed
thp wants to merge 1 commit into
masterfrom
use-gtk3-about-dialog
Closed

thp wants to merge 1 commit into
masterfrom
use-gtk3-about-dialog

Conversation

@thp

@thp thp commented Aug 18, 2021

Copy link
Copy Markdown
Member

The Gtk3 About dialog (compared to the Gtk2 one) is actually good, no need to roll our own. We do lose the bug tracker link, but it's readily available on the website ("Get help" / "Report problems at the issue tracker").

@thp

thp commented Aug 18, 2021

Copy link
Copy Markdown
Member Author

Before:

Screenshot from 2021-08-18 20-38-21

After:

Screenshot from 2021-08-18 20-38-39

(arguably this isn't strictly an improvement, but it uses more standard widgets)

@auouymous

Copy link
Copy Markdown
Member

#946 just narrowed the About dialog for mobile and this appears to fatten it back up, @tpikonen is this an issue?

@tpikonen

Copy link
Copy Markdown
Contributor

@auouymous, yes and no. The mobile linux distros (pmOS, mobian, pureOS) patch GTK to fix (among other things) the built-in about dialog, but a lot apps are now distributed with flatpak, which comes with it's own unpatched GTK.

The unpatched GTK about dialog is not totally unusable on mobile screens, but the current one in gPodder is better.

@auouymous

Copy link
Copy Markdown
Member

The native dialog assumes gvfs which results in unclickable links when not installed, the fix is at #1071 (comment).

@auouymous

Copy link
Copy Markdown
Member

And my about dialog (with patch) has a close button in the lower right corner, and it doesn't work.

@thp

thp commented Aug 28, 2021

Copy link
Copy Markdown
Member Author

Let's keep it as-is for now.. Once Gtk/Flatpak/mobile distros have figured out a way to have the stock dialog properly in all cases, including Flatpak, we can probably revisit that...

@thp thp closed this Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants