Conversation
Member
Author
Member
Contributor
|
@auouymous, yes and no. The mobile linux distros (pmOS, mobian, pureOS) patch GTK to fix (among other things) the built-in about dialog, but a lot apps are now distributed with flatpak, which comes with it's own unpatched GTK. The unpatched GTK about dialog is not totally unusable on mobile screens, but the current one in gPodder is better. |
Member
|
The native dialog assumes gvfs which results in unclickable links when not installed, the fix is at #1071 (comment). |
Member
|
And my about dialog (with patch) has a close button in the lower right corner, and it doesn't work. |
Member
Author
|
Let's keep it as-is for now.. Once Gtk/Flatpak/mobile distros have figured out a way to have the stock dialog properly in all cases, including Flatpak, we can probably revisit that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The Gtk3 About dialog (compared to the Gtk2 one) is actually good, no need to roll our own. We do lose the bug tracker link, but it's readily available on the website ("Get help" / "Report problems at the issue tracker").