Sitelet https://github.com/gpodder/gpodder/pull/1112
Skip to content

Fix linting issues from #1054 - #1112

Merged
auouymous merged 2 commits into
gpodder:masterfrom
auouymous:fix-1054-linting
Jul 30, 2021
Merged

auouymous merged 2 commits into
gpodder:masterfrom
auouymous:fix-1054-linting

Conversation

@auouymous

Copy link
Copy Markdown
Member

I can't test syncing, can someone confirm the change from lambda to def is correct? There are four other linting errors I don't know how to fix. @blushingpenguin What is the purpose of the comment in the last error?

src/gpodder/util.py:2277:5: E129 visually indented line with same indent as next logical line
src/gpodder/gtkui/main.py:3704:5: E129 visually indented line with same indent as next logical line
src/gpodder/gtkui/main.py:3733:46: E114 indentation is not a multiple of four (comment)
src/gpodder/gtkui/main.py:3733:46: E116 unexpected indentation (comment)

@elelay
elelay force-pushed the fix-1054-linting branch from 9c60658 to 106e2f4 Compare July 29, 2021 19:52
@elelay

elelay commented Jul 29, 2021

Copy link
Copy Markdown
Member

@auouymous here is a fix for remaining linter errors.
See b40f283 for the last one: @blushingpenguin removed the self.set_download_list_state callback in the end of on_synchronize_episodes

@elelay

elelay commented Jul 29, 2021

Copy link
Copy Markdown
Member

Syncing to a /tmp/XXXX directory works with the patches.

@auouymous
auouymous merged commit 3c2362e into gpodder:master Jul 30, 2021
@auouymous
auouymous deleted the fix-1054-linting branch July 30, 2021 00:02
@blushingpenguin

Copy link
Copy Markdown
Contributor

@auouymous that was just some code i commented out temporarily, but then didn't use and forgot to delete the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants