Sitelet https://github.com/gpodder/gpodder/pull/1060
Skip to content

Add tools/requirements.txt - #1060

Merged
elelay merged 1 commit into
gpodder:masterfrom
tpikonen:requirements-txt
Jun 5, 2021
Merged

elelay merged 1 commit into
gpodder:masterfrom
tpikonen:requirements-txt

Conversation

@tpikonen

@tpikonen tpikonen commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

There seems to be no machine readable dependency list for the Python packages used by gPodder. This PR adds a pip-compatible requirements file, which can be used to get the correct dependencies. I hope I did not miss anything.

I needed this when fixing the dependencies in the flatpak package. There's a tool called flatpak-pip-generator which converts the requirements file to the format understood by flatpak-builder.

@auouymous

Copy link
Copy Markdown
Member

I know nothing about this but should it be in the root directory like other projects?

Should it have the following dependencies?

webencodings==0.5.1
certifi==2020.11.8
chardet==4.0.0
idna==3.1
PySocks==1.7.1

PyPI / pip dependencies for running gPodder.
@tpikonen
tpikonen force-pushed the requirements-txt branch from afc31c6 to 77a78d0 Compare June 4, 2021 07:39
@tpikonen

tpikonen commented Jun 4, 2021

Copy link
Copy Markdown
Contributor Author

I don't mind putting the requirements to the root dir, but since gPodder is not in PyPI, I don't think it needs to be there. The other installer related files are all under tools/, including tools/mac-osx/release_on_mac.sh and tools/win_installer/_base.sh which contain a variant of this list.

The packages you list are all pulled in by pip as dependencies for requests or html5lib (webencodings). PySocks was missing, but is now pulled in by 'requests[socks]'. There's no direct imports of these in the code, so letting pip handle the versioning should be fine.

@tpikonen tpikonen closed this Jun 4, 2021
@tpikonen tpikonen reopened this Jun 4, 2021
@tpikonen

tpikonen commented Jun 4, 2021 •

Copy link
Copy Markdown
Contributor Author

BTW, there should perhaps also be a 'requirements-test.txt' file, which would have the testing dependencies listed in the README.

@elelay
elelay merged commit eba5fbd into gpodder:master Jun 5, 2021
@elelay

elelay commented Jun 5, 2021

Copy link
Copy Markdown
Member

Merged, thanks. That would solve the Tor user issue #1026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants