Sitelet https://github.com/gpodder/gpodder/pull/1028/files
Skip to content

Create config file with group/world permissions revoked #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elelay merged 1 commit into from
May 10, 2021
Merged

Create config file with group/world permissions revoked #1028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/gpodder/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import atexit
import logging
import os
import shutil
import time

import gpodder
Expand Down Expand Up @@ -347,14 +346,17 @@ def save(self, filename=None):
logger.info('Flushing settings to disk')

try:
fp = open(filename + '.tmp', 'wt')
fp.write(repr(self.__json_config))
fp.close()
# revoke unix group/world permissions (this has no effect under windows)
umask = os.umask(0o077)
with open(filename + '.tmp', 'wt') as fp:
fp.write(repr(self.__json_config))
util.atomic_rename(filename + '.tmp', filename)
except:
logger.error('Cannot write settings to %s', filename)
util.delete_file(filename + '.tmp')
raise
finally:
os.umask(umask)

self.__save_thread = None

Expand Down