Sitelet https://github.com/googleapis/google-cloud-ruby/pull/3685
Skip to content

Add Ordering Keys - #3685

Merged
blowmage merged 1 commit into
googleapis:masterfrom
blowmage:pubsub/ordering-keys
Oct 22, 2019
Merged

Add Ordering Keys#3685
blowmage merged 1 commit into
googleapis:masterfrom
blowmage:pubsub/ordering-keys

Conversation

@blowmage

@blowmage blowmage commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

These new feature add the ability to ensure related messages are published in
the order they were provided to the client. And to ensure related messages are
sent to subscribers in the order in which they were published. Messages can be
tagged with an ordering key, a string that identifies related messages for which
publish order should be respected.

@blowmage blowmage added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: pubsub Issues related to the Pub/Sub API. labels Jul 18, 2019
@blowmage
blowmage requested a review from a team July 18, 2019 23:02
@blowmage blowmage self-assigned this Jul 18, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2019
blowmage
blowmage commented Jul 18, 2019
View reviewed changes
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/errors.rb Outdated
kamalaboulhosn
kamalaboulhosn suggested changes Aug 6, 2019
View reviewed changes
Comment thread google-cloud-pubsub/OVERVIEW.md Outdated
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/subscription.rb Outdated
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher/batch.rb Outdated
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher/batch.rb Outdated
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher.rb Outdated
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/subscriber/sequencer.rb Outdated
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/subscriber/sequencer.rb Outdated
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/subscriber/sequencer.rb Outdated
@blowmage
blowmage force-pushed the pubsub/ordering-keys branch from 8957873 to 6b36b0a Compare August 6, 2019 16:32
@blowmage
blowmage force-pushed the pubsub/ordering-keys branch from b44d94a to 9195b2b Compare August 14, 2019 16:28
@blowmage

blowmage commented Aug 14, 2019

Copy link
Copy Markdown
Contributor Author

PR has been rebased on master.

@blowmage
blowmage force-pushed the pubsub/ordering-keys branch from 9195b2b to d6f08f5 Compare September 12, 2019 22:30
kamalaboulhosn
kamalaboulhosn approved these changes Sep 19, 2019
View reviewed changes
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/topic.rb Outdated
@blowmage
blowmage force-pushed the pubsub/ordering-keys branch from d6f08f5 to bc760c7 Compare September 19, 2019 14:21
@blowmage

blowmage commented Sep 19, 2019

Copy link
Copy Markdown
Contributor Author

I've rebased this PR to pick up and resolve conflicts with some fixes to Subscriber#stop.

@blowmage
blowmage force-pushed the pubsub/ordering-keys branch from 41185c6 to 1e64180 Compare September 27, 2019 22:51
@blowmage blowmage removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 27, 2019
@blowmage

blowmage commented Sep 27, 2019

Copy link
Copy Markdown
Contributor Author

@dazuma @quartzmo I've done some stress and performance testing and this feature is ready for final review. The Pub/Sub team has already approved the approach used, but we need to make sure the code is correctly implemented. I'd like to look closely at the concurrency used in particular.

dazuma
dazuma suggested changes Sep 30, 2019
View reviewed changes
Comment thread google-cloud-pubsub/OVERVIEW.md Outdated
Comment thread google-cloud-pubsub/OVERVIEW.md Outdated
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher.rb Outdated
dazuma
dazuma reviewed Sep 30, 2019
View reviewed changes
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher.rb Outdated
dazuma
dazuma reviewed Sep 30, 2019
View reviewed changes
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher.rb Outdated
dazuma
dazuma reviewed Sep 30, 2019
View reviewed changes
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher.rb Outdated
@blowmage
blowmage force-pushed the pubsub/ordering-keys branch from 9d7183f to 665f1fa Compare September 30, 2019 20:32
dazuma
dazuma reviewed Sep 30, 2019
View reviewed changes
Comment thread google-cloud-pubsub/lib/google/cloud/pubsub/subscriber/sequencer.rb Outdated
@blowmage
blowmage force-pushed the pubsub/ordering-keys branch 2 times, most recently from e8058d3 to 4238f8d Compare October 7, 2019 17:11
dazuma
dazuma approved these changes Oct 7, 2019
View reviewed changes

@dazuma dazuma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@blowmage
Add Ordering Keys
c3c7979 
These new feature add the ability to ensure related messages are published in
the order they were provided to the client. And to ensure related messages are
sent to subscribers in the order in which they were published. Messages can be
tagged with an ordering key, a string that identifies related messages for which
publish order should be respected.
@blowmage
blowmage force-pushed the pubsub/ordering-keys branch from 4238f8d to c3c7979 Compare October 22, 2019 21:39
@blowmage
blowmage merged commit 4300beb into googleapis:master Oct 22, 2019
@blowmage blowmage mentioned this pull request Nov 11, 2019
Closed
@jensljungblad jensljungblad mentioned this pull request Feb 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@dazuma dazuma dazuma approved these changes
@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@blowmage blowmage

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blowmage @dazuma @kamalaboulhosn @googlebot