Repository navigation
chore: remove dead version check conditional - #19061
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes conditional checks and fallback logic for the version_header module from google-api-core, implying that the minimum supported version of google-api-core is now 2.19.0 or higher. It cleans up templates, generated golden files, and tests by removing try/except imports, HAS_GOOGLE_API_CORE_VERSION_HEADER checks, and conditional test skips. I have no further feedback to provide as there are no review comments.
daniel-sanche
marked this pull request as ready for review
November 13, 2026 03:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator was generating a stale
HAS_GOOGLE_API_CORE_VERSION_HEADERflag, which is only read on api_core < 2.19.0. Because we now have a higher floor, we can remove this flag and related TODOs