Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request drops support for Python 3.10, adds support for Python 3.15, and bumps the minimum required versions of several dependencies, including SQLAlchemy (to >=1.4.41) and PyArrow (to >=10.0.1). Consequently, legacy compatibility checks and workarounds for older Python and SQLAlchemy versions have been cleaned up across the codebase, documentation, and test suites. Feedback on the changes suggests further cleaning up noxfile.py by removing "3.10" from ALL_PYTHON to prevent redundant, skipped test sessions, and unifying it with UNIT_TEST_PYTHON_VERSIONS.
| ALL_PYTHON: List[str] = [ | ||
| "3.10", | ||
| "3.11", | ||
| "3.12", | ||
| "3.13", | ||
| "3.14", | ||
| "3.15", | ||
| ] | ||
| ALL_PYTHON = list(UNIT_TEST_PYTHON_VERSIONS) | ||
| UNIT_TEST_PYTHON_VERSIONS: List[str] = [ | ||
| "3.11", | ||
| "3.12", | ||
| "3.13", | ||
| "3.14", | ||
| "3.15", | ||
| ] |
There was a problem hiding this comment.
Since support for Python 3.10 is being dropped, "3.10" should be removed from ALL_PYTHON as well. Keeping it in ALL_PYTHON causes sessions like system_noextras (which uses ALL_PYTHON) to be parameterized for Python 3.10, only to be skipped immediately. Unifying UNIT_TEST_PYTHON_VERSIONS and ALL_PYTHON simplifies the configuration. Additionally, ensure that the project's metadata in setup.py or pyproject.toml is also updated to reflect the same minimum version (Python 3.11) in python_requires and Trove classifiers.
| ALL_PYTHON: List[str] = [ | |
| "3.10", | |
| "3.11", | |
| "3.12", | |
| "3.13", | |
| "3.14", | |
| "3.15", | |
| ] | |
| ALL_PYTHON = list(UNIT_TEST_PYTHON_VERSIONS) | |
| UNIT_TEST_PYTHON_VERSIONS: List[str] = [ | |
| "3.11", | |
| "3.12", | |
| "3.13", | |
| "3.14", | |
| "3.15", | |
| ] | |
| ALL_PYTHON: List[str] = [ | |
| "3.11", | |
| "3.12", | |
| "3.13", | |
| "3.14", | |
| "3.15", | |
| ] | |
| UNIT_TEST_PYTHON_VERSIONS: List[str] = ALL_PYTHON |
References
- When updating the minimum supported Python version in runtime checks (e.g., 'sys.version_info' checks), ensure that the project's metadata in 'setup.py' or 'pyproject.toml' is also updated to reflect the same minimum version in 'python_requires' and Trove classifiers.
There was a problem hiding this comment.
I believe that would break GitHub Actions.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issues b/581948327 b/581950408 🦕