Sitelet https://github.com/googleapis/google-cloud-java/pull/181
Skip to content

Add third RetryResult (instead of using null) to denote 'proceed' - #181

Merged
aozarov merged 2 commits into
googleapis:masterfrom
ajkannan:add-retry-result-value
Sep 26, 2015
Merged

Add third RetryResult (instead of using null) to denote 'proceed'#181
aozarov merged 2 commits into
googleapis:masterfrom
ajkannan:add-retry-result-value

Conversation

@ajkannan

@ajkannan ajkannan commented Sep 25, 2015

Copy link
Copy Markdown

This PR addresses fixes #105

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2015
aozarov
aozarov reviewed Sep 25, 2015
View reviewed changes
Comment thread gcloud-java-core/src/main/java/com/google/gcloud/ExceptionHandler.java Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ajkannan ajkannan removed the auth label Sep 25, 2015
aozarov
aozarov reviewed Sep 25, 2015
View reviewed changes
Comment thread gcloud-java-core/src/main/java/com/google/gcloud/ExceptionHandler.java Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ajkannan
ajkannan force-pushed the add-retry-result-value branch from d49ac54 to 800b709 Compare September 25, 2015 21:29
@ajkannan

ajkannan commented Sep 25, 2015

Copy link
Copy Markdown
Author

Related question, but perhaps not for this PR: should we write tests for DatastoreImpl.java and StorageImpl.java to make sure the interceptor works as intended?

@aozarov
aozarov merged commit 48458d3 into googleapis:master Sep 26, 2015
@aozarov aozarov mentioned this pull request Sep 26, 2015
Closed
@aozarov

ghost commented Sep 26, 2015

Copy link
Copy Markdown
Contributor

Related question, but perhaps not for this PR: should we write tests for DatastoreImpl.java and StorageImpl.java to make sure the interceptor works as intended?

Yes, I think we should test exception handling in the Datastore.
Can you create a separate issue for it?

@ajkannan
ajkannan deleted the add-retry-result-value branch September 28, 2015 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ExceptionHandler.Interceptor.RetryResult should have a third value, used instead of null

3 participants

@ajkannan @aozarov @googlebot