Repository navigation
Is StorageService.load the right name? #56
Description
Activity
- addedtype: questionRequest for information or clarification. Not an issue.Request for information or clarification. Not an issue.api: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.
on May 12, 2015 - modified the milestones: This milestone has been deleted, This milestone has been deleted
on Jun 1, 2015 @jgeewax , I don't think this belongs in this milestone as as I think the answer for this API questions would benefit from a wider set of opinions.
Can you clarify why? I think this belongs here because naming stuff is something relatively easy to discuss, and would make things a bit more stable once we have outsiders using the library.
In short, I think it's worth having and resolving this discussion before a public announcement.
As you can see, this issue is open for 21 days with no further comments/suggestions.
Clearly I liked "load" in this case (trying to make it clear that the complete content would be fetched and loaded into memory) and for that reason I names it as such.I don't like download (which to me is more associated with save-to-disk) but I can live with read (though to me that normally is associated with a range/chunk rather than the complete content). I don't mind to change it to read (or its variants) but would that really be better? This is why I think we should wait until announced, so we can get more opinions...
Recapping the options based on your feedback:
load: Seems clear about the action, it's putting stuff to memorydownload: I can agree that this tends to me "put to disk" so I can understand that.read: I could go either way on this, not entirely sure.getBytes: Seems like a very clear method name... I kind of like this oneloadByteswasn't on the list, but I like this too.
I still don't know if we have enough to call this discussion "closed", would love to start crossing off the different options and getting a bit of feedback.
readAllByteswould be consistent withjava.nio.FilesI am fine with
readAllBytes. Pull request #89Merged
16 remaining items
- added a commit that references this issue
on Nov 19, 2022 - added a commit that references this issue
on Dec 22, 2025 - added 2 commits that reference this issue
on Jan 6, 2026 - added a commit that references this issue
on Jan 22, 2026 - added a commit that references this issue
on Feb 24, 2026 - added a commit that references this issue
on Mar 11, 2026 - added a commit that references this issue
on Mar 12, 2026 - added a commit that references this issue
on Mar 30, 2026 - added a commit that references this issue
on Apr 1, 2026 - added 2 commits that reference this issue
on Apr 29, 2026 - added a commit that references this issue
on Jul 13, 2026
Right now, to load a Blob into a byte array, we use the
loadmethod:Is
loadthe right verb for this? (Not saying it's wrong, just want to discuss this one here.)Some of the options:
load(This is what it is today)downloadreadgetBytesreadBytes