Sitelet https://github.com/googleapis/google-cloud-java/issues/1532
Skip to content

Deprecate AsyncLoggingHandler? #1532

Description

@gregw

The fix for #1386 has made the normal LoggingHandler asynchronous! Was this deliberate? If so, should the AsyncLoggingHandler be deprecated as it now no longer changes behaviour.

Activity

  1. garrettjonesgoogle commented on Jan 13, 2017

    @garrettjonesgoogle
    Contributor

    Hmm I think I should actually switch the main one back to synchronous. I overlooked the separate asynchronous class which people can use. What I do think should be done though is to switch the example to suggest the asynchronous one because it will be more performant.

  2. garrettjonesgoogle commented on Jan 26, 2017

    @garrettjonesgoogle
    Contributor

    I think this needs to be cleaned up before GA.

  3. garrettjonesgoogle commented on Mar 1, 2017

    @garrettjonesgoogle
    Contributor

    We should delete this altogether, and support a setting for sync v async in the logging config.

  4. michaelbausor commented on Mar 9, 2017

    @michaelbausor
    Contributor

    Closed in #1716

  5. gregw commented on Mar 9, 2017

    @gregw
    Author

    Could the AsyncLoggingHandler be left as a deprecated extension of LoggingHandler, as that will make transitioning usage easier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: loggingIssues related to the Cloud Logging API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions