Sitelet https://github.com/googleapis/google-api-php-client/pull/2643
Skip to content

chore: add php 8.4 to test matrix - #2643

Merged
bshaffer merged 1 commit into
mainfrom
add-php84
Dec 4, 2024
Merged

bshaffer merged 1 commit into
mainfrom
add-php84

Conversation

@bshaffer

@bshaffer bshaffer commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@bshaffer
bshaffer requested a review from a team December 3, 2024 15:41
fail-fast: false
matrix:
php: [ "8.0", "8.1", "8.2", "8.3" ]
php: [ "8.0", "8.1", "8.2", "8.3", "8.4" ]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The services repo does not depend on Auth but this one does, shouldn't we remove the "8.0" support?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I miss-interpreted the conversation in our chat, I thought we were going to remove support here instead of my own PR.

Approved.

@bshaffer
bshaffer merged commit 8142a3e into main Dec 4, 2024
@bshaffer
bshaffer deleted the add-php84 branch December 4, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants