Repository navigation
re2: use new absl::Mutex method names and MutexLock(Mutex&) - #665
Open
edwinchenloo wants to merge 1 commit into
Open
edwinchenloo wants to merge 1 commit into
edwinchenloo wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
edwinchenloo
force-pushed
the
absl-mutex-api
branch
from
September 30, 2026 18:50
bbf7b49 to
f4ed898
Compare
Replace the deprecated ReaderLock/ReaderUnlock/WriterLock/WriterUnlock with lock_shared/unlock_shared/lock/unlock, and pass a reference rather than a pointer to absl::MutexLock in regexp.cc, completing the update for the Abseil API churn from mid-2025.
edwinchenloo
force-pushed
the
absl-mutex-api
branch
from
September 30, 2026 18:52
f4ed898 to
15ed4e7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 972a15c ("re2: remove unnecessary & in MutexLock usage"), finishing the update for the mid-2025 Abseil API changes:
re2/dfa.cc:RWLockernow useslock_shared/unlock_shared/lock/unlockinstead of the deprecatedReaderLock/ReaderUnlock/WriterLock/WriterUnlock.re2/regexp.cc: pass*ref_mutex()toabsl::MutexLock(the reference constructor) instead of the pointer.Starting with Abseil LTS 20260107, the old method names and the pointer
MutexLockconstructor are marked[[deprecated]], so building RE2 against current Abseil emits deprecation warnings indfa.ccandregexp.cc(and fails outright under-Werror). This change removes those warnings. It doesn't raise the minimum Abseil version: 972a15c already requires 20250814, which provides both the old and new APIs.Tested with
bazel test //:all(20/20 pass).