Sitelet https://github.com/gitpython-developers/GitPython/pull/2219/files
Skip to content

fix: wait for git daemon to listen before connecting #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 1 commit into from
Aug 28, 2026
+10 −2
Merged

fix: wait for git daemon to listen before connecting #2219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions test/lib/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import os
import os.path as osp
from stat import S_ISLNK, ST_MODE
import socket
import subprocess
import sys
import tempfile
Expand Down Expand Up @@ -218,8 +219,15 @@ def git_daemon_launched(base_path, ip, port):
base_path=base_path,
as_process=True,
)
# Yes, I know... fortunately, this is always going to work if sleep time is just large enough.
time.sleep(1.0 if sys.platform == "win32" else 0.5)

# Wait until git daemon listens for connections.
for _attempt in range(1, 30):
try:
socket.create_connection((ip, port), timeout=30).close()
break
except ConnectionRefusedError:
time.sleep(0.5)

except Exception as ex:
msg = textwrap.dedent(
"""
Expand Down
Loading